enhance(oidc): add more claims #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1172 +/- ##
==========================================
- Coverage 52.85% 52.84% -0.02%
==========================================
Files 551 551
Lines 19182 19199 +17
==========================================
+ Hits 10139 10146 +7
- Misses 8479 8489 +10
Partials 564 564
|
wass3r
reviewed
Aug 27, 2024
|
Is there an intention to follow up this PR with the API implementation here? |
ecrupper
approved these changes
Aug 28, 2024
wass3r
approved these changes
Aug 28, 2024
plyr4
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes go-vela/community#996
Note: I intended to include whether the build was triggered from a fork, but it seems we don’t currently store that information in the database. Therefore, I decided to omit that detail for now. If someone wants to add this feature in the future, they will also need to update the database to capture this data.